Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Modify test_positive_import_all_roles to cover non-admin scenario #15252

Merged
merged 1 commit into from
May 31, 2024
Merged

[6.15.z] Modify test_positive_import_all_roles to cover non-admin scenario #15252

merged 1 commit into from
May 31, 2024
+21 −2

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #15171

Problem Statement

Currently, test_positive_import_all_roles covers only admin scenario to import all roles via UI, and as part of component audit its suggest to modify this test to cover non-admin user scenario

Solution

Parametrizing the existing test to cover both admin and non-admin user scenarios with few more changes

@Satellite-QE Satellite-QE added the 6.15.z Introduced in or relating directly to Satellite 6.15 label May 31, 2024
@Satellite-QE Satellite-QE requested a review from a team as a code owner May 31, 2024 01:06
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels May 31, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 31, 2024
@Satellite-QE Satellite-QE merged commit 5ce30de into 6.15.z May 31, 2024
15 of 16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-ba922c8078afb9370db578b664ff925f398938df branch May 31, 2024 01:17
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 7222
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ansible.py::test_positive_import_all_roles --external-logging
Test Result : ================= 2 passed, 187 warnings in 2110.85s (0:35:10) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @Gauravtalreja1